Skip to content

Register for events in the proper DOM. #3247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jimfb wants to merge 1 commit into from
Closed

Register for events in the proper DOM. #3247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/browser/ui/ReactDOMComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ var CONTENT_TYPES = {'string': true, 'number': true};
var STYLE = keyOf({style: null});

var ELEMENT_NODE_TYPE = 1;
var DOC_NODE_TYPE = 9;
var DOCUMENT_FRAGMENT_NODE_TYPE = 11;

/**
* Optionally injectable operations for mutating the DOM
Expand Down Expand Up @@ -100,9 +102,19 @@ function putListener(id, registrationName, listener, transaction) {
}
var container = ReactMount.findReactContainerForID(id);
if (container) {
var doc = container.nodeType === ELEMENT_NODE_TYPE ?
container.ownerDocument :
container;

var doc = container; // Walk up from container to find best document
while (doc !== null &&
doc.nodeType !== DOC_NODE_TYPE &&
doc.nodeType !== DOCUMENT_FRAGMENT_NODE_TYPE) {
doc = doc.parentNode;
}

// If the container isn't mounted in a document, register with the default document
if (doc === null && container.nodeType === ELEMENT_NODE_TYPE) {
doc = container.ownerDocument;
}

listenTo(registrationName, doc);
}
transaction.getPutListenerQueue().enqueuePutListener(
Expand Down