Add support for the svg cursor attribute #3326
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
# Conflicts: # src/renderers/dom/shared/SVGDOMPropertyConfig.js
darcyadams
force-pushed
the
svg-cursor-attribute
branch
from
6d79d74 to
03df276
Compare
Contributor
|
@darcyadams updated the pull request. |
Contributor
Author
|
moved this enhancement over to the current master branch. |
Collaborator
|
Thank you for the PR, and sorry about the long wait. Now that #5714 is merged, all attributes on SVG elements will be passed through as is, with no need for the whitelist. I'm closing this but please let me know if you have any troubles in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React strips the
cursorattribute from svg elements. This PR just adds it to the list of supported svg attributes.See docs here
It is not possible to style the cursor on svg elements with css. So this is a limiting factor when using svg to draw portions of a UI.