Skip to content

Warn with two copies of React #3332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sophiebits merged 1 commit into from
Aug 12, 2015
Merged

Warn with two copies of React #3332

sophiebits merged 1 commit into from
Aug 12, 2015

Conversation

@sophiebits
Copy link
Collaborator

@sophiebits sophiebits commented Mar 6, 2015

No description provided.

@sophiebits
Copy link
Collaborator Author

sophiebits commented Mar 6, 2015

I was gonna just add a comment, but we may as well add a full-blown warning.

@sophiebits
Copy link
Collaborator Author

sophiebits commented Mar 6, 2015

Hm, my test passes in jest but fails in grunt test.

@aaronshaf
Copy link

aaronshaf commented Mar 24, 2015

This would be great!

@sophiebits sophiebits mentioned this pull request Apr 9, 2015
Merged
@sebmarkbage
Copy link
Collaborator

sebmarkbage commented May 14, 2015

Fix travis and then ship it?

@sophiebits
Copy link
Collaborator Author

sophiebits commented May 31, 2015

@sebmarkbage Fixed Travis.

@chrisirhc
Copy link

chrisirhc commented Jul 29, 2015

Ping, seems like this PR is getting stale. I'm happy to re-roll this into a new fix if this needs some conflict resolution. Hitting this in multiple places.

@sophiebits sophiebits added this to the 0.14 milestone Jul 29, 2015
@sophiebits
Copy link
Collaborator Author

sophiebits commented Jul 29, 2015

Couldn't rebase this to have it work at a first attempt. Maybe we work properly on this now? Not sure.

@chrisirhc chrisirhc mentioned this pull request Jul 31, 2015
Closed
sophiebits added a commit that referenced this pull request Aug 12, 2015
@sophiebits
Merge pull request #3332 from spicyj/warn-r2
655b82f 
Warn with two copies of React
@sophiebits sophiebits merged commit 655b82f into facebook:master Aug 12, 2015
@JedWatson
Copy link
Contributor

JedWatson commented Aug 12, 2015

😀 so happy about this - it's going to make so many support issues just disappear. Thanks @spicyj and everyone!

@sophiebits
Copy link
Collaborator Author

sophiebits commented Aug 12, 2015

0.14 also has a few other improvements that should make having multiple copies of React no longer a problem in some cases so hopefully people stop running into these problems.

@JedWatson Thank you.

gaearon
gaearon reviewed Aug 12, 2015
View reviewed changes
src/renderers/dom/client/__tests__/ReactMount-test.js
Copy link
Collaborator

@gaearon gaearon Aug 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit confused, why is .only there?

Copy link
Collaborator Author

@sophiebits sophiebits Aug 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake, thanks.

Copy link
Collaborator Author

@sophiebits sophiebits Aug 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(#4609)

@jimfb jimfb mentioned this pull request Nov 10, 2015
Closed
@jfairley jfairley mentioned this pull request Nov 19, 2015
Closed
@sheepsteak sheepsteak mentioned this pull request Nov 26, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

0.14

Development

Successfully merging this pull request may close these issues.

7 participants

@sophiebits @aaronshaf @sebmarkbage @chrisirhc @JedWatson @gaearon @facebook-github-bot