[docs] React.cloneElement #3363
Conversation
There was a problem hiding this comment.
we are missing a type on children
There was a problem hiding this comment.
Doesn't have a type, it's var args and can be an array, an element, a string, a number, a bool... which basically maps to ReactNode but that's not really a super well defined type, so meh. We already have it exactly like this for createElement
There was a problem hiding this comment.
if it's a varargs, it shouldn't be inside array brackets, should it?
There was a problem hiding this comment.
its optional.
anyway, let's fix all of these as a whole. if you really want to do it now, do it and make sure it happens in all our API docs. But we won't change just this one - this fits with the rest.
There was a problem hiding this comment.
Meh, I prefer incremental correctness over consistency, but sure. Looks good to me.
2 participants
No description provided.