[Flight] Skip the stack frame of built-in wrappers that create or await Promises#33798
Conversation
github-actions
bot
added
the
React Core Team
| 0, | ||
| 0, | ||
| 0, | ||
| ], |
There was a problem hiding this comment.
This is on the stack of where the thing happens. Since this implementation choses to include anonymous locations, it'll also have this on the stack. However it will not have the "new Promise" on the top of the stack.
| "value": [ | ||
| , | ||
| ], | ||
| "value": undefined, |
There was a problem hiding this comment.
This is now using the await inside the Promise.all and its "value" is the return value of the delay (undefined). Previously, the Promise.all call was skipped and it used the await of the Promise.all instead. So we get the value of the last resolved I/O of the set, which is also the stack that we get.
The tradeoff is that we don't see all the values of a set if multiple things are awaited but that's not what we're modeling in this entry anyway since it won't have the time spans and stacks for earlier resolutions anyway.
sebmarkbage
force-pushed
the
promisespecialcases
branch
from
d7abbb2 to
534b056
Compare
…it Promises (facebook#33798) We already do this with `"new Promise"` and `"Promise.then"`. There are also many helpers that both create promises and awaits other promises inside of it like `Promise.all`. The way this is filtered is different from just filtering out all anonymous stacks since they're used to determine where the boundary is between ignore listed and user space. Ideally we'd cover more wrappers that are internal to Promise libraries. DiffTrain build for [da7487b](facebook@da7487b)
3 participants
We already do this with
"new Promise"and"Promise.then". There are also many helpers that both create promises and awaits other promises inside of it likePromise.all.The way this is filtered is different from just filtering out all anonymous stacks since they're used to determine where the boundary is between ignore listed and user space.
Ideally we'd cover more wrappers that are internal to Promise libraries.