InferEffectDeps takes a React.AUTODEPS sigil#33799
Merged
jbrown215 merged 1 commit intofacebook:mainfrom Jul 17, 2025
Merged
Conversation
jbrown215
commented
Jul 16, 2025
| if ( | ||
| value.args.length === autodepFnLoads.get(callee.identifier.id) && | ||
| value.args.length > 1 && | ||
| autodepsArgIndex > 0 && |
Contributor
Author
There was a problem hiding this comment.
In the next diff I change the config to specify the index for autodeps instead of number of required args
mofeiZ
reviewed
Jul 16, 2025
| BuiltInUseEffectEventId, | ||
| ), | ||
| ], | ||
| ['AUTODEPS', addObject(DEFAULT_SHAPES, BuiltInAutodepsId, [])], |
Contributor
There was a problem hiding this comment.
supernit -- should this be prefixed with experimental_ / unstable_?
mofeiZ
reviewed
Jul 16, 2025
| ```javascript | ||
| // @inferEffectDependencies @panicThreshold:"none" | ||
| import { useEffect } from "react"; | ||
| import { useEffect, AUTODEPS } from "react"; |
Contributor
There was a problem hiding this comment.
Makes sense that we don't rewrite the import (yet)
mofeiZ
reviewed
Jul 16, 2025
| function ReactiveVariable({ propVal }) { | ||
| const arr = [propVal]; | ||
| useEffectWrapper(() => print(arr)); | ||
| useEffectWrapper(() => print(arr), AUTODEPS); |
Contributor
There was a problem hiding this comment.
This makes sense since we're in no-emit
mofeiZ
approved these changes
Jul 16, 2025
Contributor
mofeiZ
left a comment
mofeiZ
left a comment
There was a problem hiding this comment.
Nice!! I read through the fixtures to confirm that (1) we're currently detecting + deleting AUTODEPS references and (2) logger diagnostics stay unchanged (except for line numbers)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 17, 2025
--- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33799). * #33800 * __->__ #33799 DiffTrain build for [dffacc7](dffacc7)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 17, 2025
--- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33799). * #33800 * __->__ #33799 DiffTrain build for [dffacc7](dffacc7)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Jul 20, 2025
--- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33799). * facebook#33800 * __->__ facebook#33799 DiffTrain build for [dffacc7](facebook@dffacc7)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Jul 20, 2025
--- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33799). * facebook#33800 * __->__ facebook#33799 DiffTrain build for [dffacc7](facebook@dffacc7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.