-
Notifications
You must be signed in to change notification settings - Fork 50.4k
Include the owner name when warning about createElement(null/undefined). #3433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Makes it easier to find the callsite that needs to be fixed.
|
Looks great – thanks! |
Include the owner name when warning about createElement(null/undefined).
|
(If you have a repro case, you should also be able to turn on break-on-exception in the debugger and inspect the stack trace to show you the culprit.) |
|
At least in 0.12 with the batched updates strategy that we use, the stack when the exception is thrown only has our main application entry point in it, not the immediate owner's You can use |
|
That's true, but you can put a breakpoint where the console.warn call is. If you turn on "Pause on Uncaught Exceptions" then this line should also put you in the debugger: react/src/vendor/core/warning.js Line 55 in 5d9b228
We should add a page on the React site somewhere explaining this. |
|
Neat, thanks for the tip. |
Makes it easier to find the callsite that needs to be fixed.
Builds on the warning message added by #2726