[Flight] Only use debug component info for parent stacks#34431
Merged
eps1lon merged 2 commits intofacebook:mainfrom Sep 9, 2025
Merged
[Flight] Only use debug component info for parent stacks#34431eps1lon merged 2 commits intofacebook:mainfrom
eps1lon merged 2 commits intofacebook:mainfrom
Conversation
github-actions
bot
added
the
React Core Team
|
Comparing: a9410fb...02bcec4 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
eps1lon
changed the title
eps1lon
force-pushed
the
sebbie/rsc-parent-stacks
branch
3 times, most recently
from
dea84dc to
8cc64d4
Compare
sebmarkbage
approved these changes
Sep 9, 2025
eps1lon
commented
Sep 9, 2025
| for (let i = 0; i < referencedDebugInfo.length; ++i) { | ||
| const debugInfoEntry = referencedDebugInfo[i]; | ||
| if (debugInfoEntry.name != null) { | ||
| (debugInfoEntry: ReactComponentInfo); |
Collaborator
Author
There was a problem hiding this comment.
Double checked that Flow starts erroring once we add another union member to ReactDebugInfoEntry with a name property. This type assertion ensures that future us needs to decide whether a new kind of ReactDebugInfoEntry with name should be transferred or not.
eps1lon
force-pushed
the
sebbie/rsc-parent-stacks
branch
from
8cc64d4 to
02bcec4
Compare
This was referenced Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #34229
We use Component debug info to fill in gaps between Fibers in the parent stack (for React DevTools, errorInfo.componentStack, hydration diffs, etc). It's unfortunate that this makes third-party Server Components disappear.
Before:
After: