[Compiler Bug] - rejection of valid ref initialization patterns#34518
Closed
lluisemper wants to merge 1 commit intofacebook:mainfrom
Closed
[Compiler Bug] - rejection of valid ref initialization patterns#34518lluisemper wants to merge 1 commit intofacebook:mainfrom
lluisemper wants to merge 1 commit intofacebook:mainfrom
Conversation
Allow `ref.current === undefined` and `!ref.current` patterns when using useRef(undefined). Previously, the compiler incorrectly rejected these valid ref initialization patterns due to missing refId handling in validation logic.
Member
|
Thanks for the contribution! Note that I landed support for these patterns already in #34449, we're intentional about disallowing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
ref.current === undefinedand!ref.currentpatterns when usinguseRef(undefined). Previously, the compiler incorrectly rejected these valid
ref initialization patterns due to missing refId handling in validation logic.
Summary
Fixes: #34278
How did you test this change?
Added test cases:
-
ref-undefined-initialization.js- testsref.current === undefinedpattern-
ref-undefined-initialization-negation.js- tests!ref.currentpattern-
valid-ref-initialization-unary-not.js- existing test renamed to reflect it now passes