Add IE-specific 'unselectable' attribute #3519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
Lint is complaining because you have trailing spaces here. Otherwise this is good to go.
Contributor
Author
|
Thanks - not sure how that happened with the trailing spaces but I fixed it. Should I have edited my original commit, or is a second commit OK? (Sorry, new to github) |
Member
|
Ideally squashed but I don't care much. If you update and push -f before I merge, I'll take that. |
I ended up needing to add this attribute to work around a common IE bug, that clicking on a scrollbar gives focus to the scroll container. I needed to set it as MUST_USE_ATTRIBUTE or the attribute would not be passed through by React successfully. remove trailing spaces
Contributor
Author
|
OK I squashed the commits. Thanks |
zpao
added a commit
that referenced
this pull request
Mar 30, 2015
Add IE-specific 'unselectable' attribute
zpao
added a commit
to zpao/react
that referenced
this pull request
Apr 13, 2015
Add IE-specific 'unselectable' attribute
zpao
added a commit
to zpao/react
that referenced
this pull request
Apr 17, 2015
Add IE-specific 'unselectable' attribute
zpao
added a commit
to zpao/react
that referenced
this pull request
Apr 18, 2015
Add IE-specific 'unselectable' attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up needing to add this attribute to work around a common IE bug, that clicking on a scrollbar gives focus to the scroll container. I needed to set it as MUST_USE_ATTRIBUTE or the attribute would not be passed through by React successfully.