[compiler][snap] Fix for filter mode with nested files, 'error.' prefix#35215
Merged
josephsavona merged 1 commit intomainfrom Nov 25, 2025
Merged
[compiler][snap] Fix for filter mode with nested files, 'error.' prefix#35215josephsavona merged 1 commit intomainfrom
josephsavona merged 1 commit intomainfrom
Conversation
Fixes some issues i ran into w my recent snap changes: * Correctly match against patterns that contain subdirectories, eg `fbt/fbt-call` * When checking if the input pattern has an extension, only prune known supported extensions. Our convention of `error.<name>` for fixtures that error makes the rest of the test name look like an extension to `path.extname()`. Tested with lots of different patterns including `error.` examples at the top level and in nested directories, etc.
josephsavona
force-pushed
the
pr35215
branch
from
3ff37fa to
28a2150
Compare
Member
Author
|
|
This was referenced Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes some issues i ran into w my recent snap changes:
fbt/fbt-callerror.<name>for fixtures that error makes the rest of the test name look like an extension topath.extname().Tested with lots of different patterns including
error.examples at the top level and in nested directories, etc.