[compiler] Deduplicate errors between ValidateExhaustiveDependencies and ValidatePreservedManualMemoization#35917
Merged
josephsavona merged 1 commit intomainfrom Feb 26, 2026
Merged
Conversation
…and ValidatePreservedManualMemoization When ValidateExhaustiveDependencies finds incorrect deps for a useMemo/useCallback call, ValidatePreservedManualMemoization later also fires for the same memo block, producing duplicate errors. The ExhaustiveDeps error is strictly more informative (names missing/extra deps, suggests a fix). This adds a `hasInvalidDeps` flag to StartMemoize that is set when ValidateExhaustiveDependencies produces a diagnostic. ValidatePreservedManualMemoization then skips all three of its error sites for memo blocks where this flag is set.
github-actions
bot
added
the
React Core Team
Member
Author
|
The lint issue is an existing issue not related to this diff |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 26, 2026
…and ValidatePreservedManualMemoization (#35917) With the recent changes to make the compiler fault tolerant and always continue through all passes, we can now sometimes report duplicative errors. Specifically, when `ValidateExhaustiveDependencies` finds incorrect deps for a useMemo/useCallback call, `ValidatePreservedManualMemoization` will generally also error for the same block, producing duplicate errors. The exhaustive deps error is strictly more informative, so if we've already reported the earlier error we don't need the later one. This adds a `hasInvalidDeps` flag to StartMemoize that is set when ValidateExhaustiveDependencies produces a diagnostic. ValidatePreservedManualMemoization then skips validation for memo blocks with this flag set. DiffTrain build for [6b113b7](6b113b7)
github-actions bot
pushed a commit
that referenced
this pull request
Feb 26, 2026
…and ValidatePreservedManualMemoization (#35917) With the recent changes to make the compiler fault tolerant and always continue through all passes, we can now sometimes report duplicative errors. Specifically, when `ValidateExhaustiveDependencies` finds incorrect deps for a useMemo/useCallback call, `ValidatePreservedManualMemoization` will generally also error for the same block, producing duplicate errors. The exhaustive deps error is strictly more informative, so if we've already reported the earlier error we don't need the later one. This adds a `hasInvalidDeps` flag to StartMemoize that is set when ValidateExhaustiveDependencies produces a diagnostic. ValidatePreservedManualMemoization then skips validation for memo blocks with this flag set. DiffTrain build for [6b113b7](6b113b7)
This was referenced Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the recent changes to make the compiler fault tolerant and always continue through all passes, we can now sometimes report duplicative errors. Specifically, when
ValidateExhaustiveDependenciesfinds incorrect deps for a useMemo/useCallback call,ValidatePreservedManualMemoizationwill generally also error for the same block, producing duplicate errors. The exhaustive deps error is strictly more informative, so if we've already reported the earlier error we don't need the later one.This adds a
hasInvalidDepsflag to StartMemoize that is set when ValidateExhaustiveDependencies produces a diagnostic. ValidatePreservedManualMemoization then skips validation for memo blocks with this flag set.