Skip to content

Add support for event information in React scheduler tracks in React Native#35947

Merged
rubennorte merged 1 commit intofacebook:mainfrom
rubennorte:show-event-into-in-react-perf-tracks-in-rn
Mar 3, 2026
Merged

Add support for event information in React scheduler tracks in React Native#35947
rubennorte merged 1 commit intofacebook:mainfrom
rubennorte:show-event-into-in-react-perf-tracks-in-rn

Conversation

@rubennorte
Copy link
Contributor

Summary

This defines the same fiber configuration for RN as used in DOM, so we can expose event timing information in the React scheduler tracks in performance traces.

This was unblocked by #35913 and #35912.

How did you test this change?

Manually compiled the renderer and tested e2e in FB infra:
Screenshot 2026-03-03 at 10 10 44

@react-sizebot
Copy link

react-sizebot commented Mar 3, 2026

Comparing: aac12ce...c57069b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB +0.11% 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 611.79 kB 611.79 kB = 108.12 kB 108.12 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB +0.11% 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 677.72 kB 677.72 kB = 119.08 kB 119.08 kB
facebook-www/ReactDOM-prod.classic.js = 697.72 kB 697.72 kB = 122.59 kB 122.59 kB
facebook-www/ReactDOM-prod.modern.js = 688.03 kB 688.03 kB = 120.97 kB 120.97 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
react-native/implementations/ReactFabric-profiling.js +0.32% 463.94 kB 465.40 kB +0.41% 77.96 kB 78.28 kB
react-native/implementations/ReactFabric-profiling.fb.js +0.28% 464.90 kB 466.22 kB +0.44% 78.23 kB 78.57 kB

Generated by 🚫 dangerJS against c57069b

@rubennorte rubennorte force-pushed the show-event-into-in-react-perf-tracks-in-rn branch from bfdedc1 to 627fa8f Compare March 3, 2026 10:42
Copy link
Contributor

@hoxyq hoxyq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, please fix the ESLint violation and run yarn prettier-all.

@rubennorte rubennorte force-pushed the show-event-into-in-react-perf-tracks-in-rn branch from 627fa8f to c57069b Compare March 3, 2026 12:28
@rubennorte rubennorte merged commit 4cc5b7a into facebook:main Mar 3, 2026
235 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 3, 2026
…Native (#35947)

## Summary

This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.

This was unblocked by #35913 and #35912.

## How did you test this change?

Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>

DiffTrain build for [4cc5b7a](4cc5b7a)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Mar 7, 2026
…Native (facebook#35947)

## Summary

This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.

This was unblocked by facebook#35913 and facebook#35912.

## How did you test this change?

Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>

DiffTrain build for [4cc5b7a](facebook@4cc5b7a)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Mar 7, 2026
…Native (facebook#35947)

## Summary

This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.

This was unblocked by facebook#35913 and facebook#35912.

## How did you test this change?

Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>

DiffTrain build for [4cc5b7a](facebook@4cc5b7a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants