Conversation
|
Comparing: ed69815...df5ef86 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
acdlite
left a comment
There was a problem hiding this comment.
Nice! Is it a good or a bad thing that there was already a TODO that (sorta) described the issue 😆
Discussed out-of-band, writing here for posterity:
The TODO I think is still correct, we should generalize that special-error-to-unwind-the-stack trick thing that we use for selective hydration. The main benefit is that if you're mid render it can restart immediately instead of burning cycles on a work-in-progress render that will inevitably get thrown out regardless. Leaving for a future PR in case we were to accidentally introduce a new bug in the progress.
Fixes #35821 Written/debugged by Claude. ## Test Plan - Verify undoing the source fix fails the newly added test - Verify building a bundle with the fix solves https://github.com/gaearon/react-udv-bug/ repro DiffTrain build for [c0d218f](c0d218f)
Fixes #35821 Written/debugged by Claude. ## Test Plan - Verify undoing the source fix fails the newly added test - Verify building a bundle with the fix solves https://github.com/gaearon/react-udv-bug/ repro DiffTrain build for [c0d218f](c0d218f)
Fixes #35821
Written/debugged by Claude.
Test Plan