Fix for style not always reset when set to null #3614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the style property existed, but was set to null, `this._previousStyleCopy` was not set back to `null` causing an old value to persist. This broke setting the style to `null` the next time. Fixes facebook#3606.
Member
|
👍 |
zpao
added a commit
that referenced
this pull request
Apr 7, 2015
Fix for style not always reset when set to null
zpao
added a commit
to zpao/react
that referenced
this pull request
Apr 13, 2015
Fix for style not always reset when set to null
zpao
added a commit
to zpao/react
that referenced
this pull request
Apr 17, 2015
Fix for style not always reset when set to null
zpao
added a commit
to zpao/react
that referenced
this pull request
Apr 18, 2015
Fix for style not always reset when set to null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the style property existed, but was set to null,
this._previousStyleCopywas not set back to
nullcausing an old value to persist. This broke settingthe style to
nullthe next time.Fixes #3606.