Skip to content

[performance] Replace hasOwnProperty in child processing with typeof undefined check #3665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sophiebits merged 2 commits into from
Apr 22, 2015
Merged

[performance] Replace hasOwnProperty in child processing with typeof undefined check #3665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a431a1
Replace hasOwnProperty in child processing with typeof undefined check
Apr 13, 2015
ed70d35
Update code style
Apr 14, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utils/ReactChildren.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ function mapSingleChildIntoContext(traverseContext, child, name, i) {
var mapBookKeeping = traverseContext;
var mapResult = mapBookKeeping.mapResult;

var keyUnique = !mapResult.hasOwnProperty(name);
var keyUnique = (mapResult[name] === undefined);
if (__DEV__) {
warning(
keyUnique,
Expand Down
2 changes: 1 addition & 1 deletion src/utils/flattenChildren.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ var warning = require('warning');
function flattenSingleChildIntoContext(traverseContext, child, name) {
// We found a component instance.
var result = traverseContext;
var keyUnique = !result.hasOwnProperty(name);
var keyUnique = (result[name] === undefined);
if (__DEV__) {
warning(
keyUnique,
Expand Down