Skip to content

Conversation

@zpao
Copy link
Member

@zpao zpao commented Sep 24, 2013

This creates a new standalone build which should have everything the
default build has, plus a little extra. This is not a sustainable long
term solution (we shouldn't make people choose like this) but it fixes
the problem we have in the short term.

This also removes the terrible react-transitions build. This is better
anway.

Fixes #369

Running "compare_size:files" (compare_size) task
   raw     gz Sizes
320704  62665 build/JSXTransformer.js
462810  96559 build/react-with-addons.js
 96721  27035 build/react-with-addons.min.js
429162  89475 build/react.js
 90003  25164 build/react.min.js

Let's hold off merging until:

  • We're happy with what's on React.addons (as the repo stands today)
  • We update the release tasks so react-with-addons.js gets added to the bower repo & starter kit
  • Addons builds end up in react-source gem
  • Addons builds end up on builds server
  • We have example(s) using this build
  • Update docs to mention the new build and the things that go along with it. - Initial pass at animations and transitions docs #314

@petehunt
Copy link
Contributor

Also we should remember to update/merge docs on anything we include in this build (ie TransitionGroup, Link etc)

@petehunt
Copy link
Contributor

should we throw ReactStateSetters on there?

@petehunt
Copy link
Contributor

AnalyticsEventPlugin ?

zpao added 5 commits October 8, 2013 16:49
This creates a new standalone build which should have everything the
default build has, plus a little extra. This is not a sustainable long
term solution (we shouldn't make people choose like this) but it fixes
the problem we have in the short term.

This also removes the terrible react-transitions build. This is better
anway.

Fixes facebook#369
zpao added a commit that referenced this pull request Oct 8, 2013
react-with-addons build
@zpao zpao merged commit 44352a2 into facebook:master Oct 8, 2013
@zpao zpao deleted the addons branch January 14, 2014 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

react-with-addons.js

2 participants