Skip to content

Add meta tag in the header of HTML#4334

Merged
jimfb merged 2 commits intofacebook:masterfrom
kohei-takata:add_meta_tag_in_the_header_of_html
Jul 10, 2015
Merged

Add meta tag in the header of HTML#4334
jimfb merged 2 commits intofacebook:masterfrom
kohei-takata:add_meta_tag_in_the_header_of_html

Conversation

@kohei-takata
Copy link
Copy Markdown
Contributor

refs #4267

Comment thread docs/docs/tutorial.md Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to bump this if you're adding a line so that the correct line stays highlighted.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry I can't understand what you mean.
What should I change?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 7 should become an 8. We use the {7} to highlight a line in the generated markup (see it in action @ http://facebook.github.io/react/docs/tutorial.html#adding-markdown)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks! I understand!
I've changed that.

@jimfb
Copy link
Copy Markdown
Contributor

jimfb commented Jul 10, 2015

Looks great, thanks!

jimfb added a commit that referenced this pull request Jul 10, 2015
…f_html

Add meta tag in the header of HTML in translated documentation.
@jimfb jimfb merged commit 6c0ab0b into facebook:master Jul 10, 2015
jimfb added a commit that referenced this pull request Jul 17, 2015
…f_html

Add meta tag in the header of HTML in translated documentation.
(cherry picked from commit 6c0ab0b)
dilberx pushed a commit to dilberx/react that referenced this pull request Apr 15, 2026
…header_of_html

Add meta tag in the header of HTML in translated documentation.
(cherry picked from commit 6c0ab0b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants