Skip to content

Added an invariant to throw instead of potentially failing to terminate on unexpected condition. #4502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jimfb wants to merge 1 commit into from
Closed

Added an invariant to throw instead of potentially failing to terminate on unexpected condition. #4502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/renderers/dom/client/ReactEventListener.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ var ReactUpdates = require('ReactUpdates');
var assign = require('Object.assign');
var getEventTarget = require('getEventTarget');
var getUnboundedScrollPosition = require('getUnboundedScrollPosition');
var invariant = require('invariant');

var DOCUMENT_FRAGMENT_NODE_TYPE = 11;

Expand Down Expand Up @@ -128,6 +129,12 @@ function handleTopLevelWithPath(bookKeeping) {
// Jump to the root of this React render tree
while (currentPathElementID !== newRootID) {
i++;
invariant(
i < path.length,
'Expected to find another React root ' +
'before reaching end of event path (%s).',
path
);
currentPathElement = path[i];
currentPathElementID = ReactMount.getID(currentPathElement);
}
Expand Down