Skip to content

Wrap lifecycle events with ReactPerf.measure if __DEV__ #4522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gfogle wants to merge 9 commits into from
Closed

Wrap lifecycle events with ReactPerf.measure if __DEV__ #4522

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
93c5449
hijack lifecycles in ReactClass to perf measure
gfogle Jul 28, 2015
63773f1
Merge branch 'master' into hijack-lifecycle-events
gfogle Jul 28, 2015
492f1a4
add metrics to default perf for lifecycle
gfogle Jul 28, 2015
fca37e1
seed default per test file
gfogle Jul 28, 2015
3136e20
slim PR to just ReactClass
gfogle Jul 30, 2015
9e66ec5
Merge branch 'master' into hijack-lifecycle-events
gfogle Jul 30, 2015
21001bc
fix where lifecycle events get reattached
gfogle Aug 1, 2015
2f37b4f
kill old updates to default perf
gfogle Aug 1, 2015
6e1448d
lint errors from no internal plugin
gfogle Aug 1, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/isomorphic/classic/class/ReactClass.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ var warning = require('warning');

var MIXINS_KEY = keyOf({mixins: null});

var ReactPerf = require('ReactPerf');

/**
* Policies that describe methods in `ReactClassInterface`.
*/
Expand Down Expand Up @@ -900,6 +902,16 @@ var ReactClass = {
for (var methodName in ReactClassInterface) {
if (!Constructor.prototype[methodName]) {
Constructor.prototype[methodName] = null;
} else {
if (__DEV__) {
// spec is the user-defined component
// hijack the defined lifecycle methods and wrap with Perf
spec[methodName] = ReactPerf.measure(
spec.displayName,
methodName,
spec[methodName]
);
}
}
}

Expand Down