update enqueueCallback invariant to more specifically denote type of passed callback#5193
Merged
jimfb merged 1 commit intofacebook:masterfrom Oct 16, 2015
Merged
Conversation
conorhastings
force-pushed
the
enqueue-callback-error
branch
2 times, most recently
from
7840d2f to
97abe0c
Compare
Contributor
|
@conorhastings updated the pull request. |
Contributor
|
Thanks @conorhastings, this looks great! In javascript most things are objects (so this protects against |
conorhastings
force-pushed
the
enqueue-callback-error
branch
from
97abe0c to
ba24ee5
Compare
Author
|
@jimfb updated, do you mean something like this? |
conorhastings
force-pushed
the
enqueue-callback-error
branch
from
ba24ee5 to
b5b3d4d
Compare
Contributor
|
@conorhastings updated the pull request. |
conorhastings
force-pushed
the
enqueue-callback-error
branch
from
b5b3d4d to
ca95660
Compare
Contributor
|
@conorhastings updated the pull request. |
conorhastings
force-pushed
the
enqueue-callback-error
branch
from
ca95660 to
20ec78d
Compare
Contributor
|
@conorhastings updated the pull request. |
Contributor
|
@conorhastings Yep, that looks great! Thanks! |
jimfb
added a commit
that referenced
this pull request
Oct 16, 2015
update enqueueCallback invariant to more specifically denote type of passed callback
This was referenced Mar 21, 2016
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #5172