Skip to content

Add support for SVG marker element #5398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
f4z4on wants to merge 1 commit into from
Closed

Add support for SVG marker element #5398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions docs/docs/ref-04-tags-and-attributes.it-IT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ thead time title tr track u ul var video wbr
I seguenti elementi SVG sono supportati:

```
circle clipPath defs ellipse g line linearGradient mask path pattern polygon polyline
radialGradient rect stop svg text tspan
circle clipPath defs ellipse g line linearGradient marker mask path pattern polygon
polyline radialGradient rect stop svg text tspan
```

Potresti trovare utile [react-art](https://github.com/facebook/react-art), una libreria di disegno per React che può disegnare su Canvas, SVG oppure VML (per IE8).
Expand Down Expand Up @@ -80,11 +80,13 @@ Esiste anche l'attributo specifico di React `dangerouslySetInnerHTML` ([maggiori

```
clipPath cx cy d dx dy fill fillOpacity fontFamily
fontSize fx fy gradientTransform gradientUnits markerEnd
markerMid markerStart offset opacity patternContentUnits
patternUnits points preserveAspectRatio r rx ry spreadMethod
stopColor stopOpacity stroke strokeDasharray strokeLinecap
strokeOpacity strokeWidth textAnchor transform version
viewBox x1 x2 x xlinkActuate xlinkArcrole xlinkHref xlinkRole
xlinkShow xlinkTitle xlinkType xmlBase xmlLang xmlSpace y1 y2 y
fontSize fx fy gradientTransform gradientUnits marker
markerEnd markerHeight markerMid markerStart markerUnits
markerWidth offset opacity orient patternContentUnits
patternUnits points preserveAspectRatio r refX refY rx ry
spreadMethod stopColor stopOpacity stroke strokeDasharray
strokeLinecap strokeOpacity strokeWidth textAnchor transform
version viewBox x1 x2 x xlinkActuate xlinkArcrole xlinkHref
xlinkRole xlinkShow xlinkTitle xlinkType xmlBase xmlLang
xmlSpace y1 y2 y
```
20 changes: 11 additions & 9 deletions docs/docs/ref-04-tags-and-attributes.ko-KR.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ thead time title tr track u ul var video wbr
다음의 SVG 엘리먼트가 지원됩니다.

```
circle clipPath defs ellipse g line linearGradient mask path pattern polygon polyline
radialGradient rect stop svg text tspan
circle clipPath defs ellipse g line linearGradient marker mask path pattern polygon
polyline radialGradient rect stop svg text tspan
```

아마 Canvas, SVG, VML(IE8 전용)에 렌더할 때 쓰는 React의 드로잉 라이브러리인 [react-art](https://github.com/facebook/react-art)도 흥미 있으실 수 있습니다.
Expand Down Expand Up @@ -80,11 +80,13 @@ type useMap value width wmode wrap

```
clipPath cx cy d dx dy fill fillOpacity fontFamily
fontSize fx fy gradientTransform gradientUnits markerEnd
markerMid markerStart offset opacity patternContentUnits
patternUnits points preserveAspectRatio r rx ry spreadMethod
stopColor stopOpacity stroke strokeDasharray strokeLinecap
strokeOpacity strokeWidth textAnchor transform version
viewBox x1 x2 x xlinkActuate xlinkArcrole xlinkHref xlinkRole
xlinkShow xlinkTitle xlinkType xmlBase xmlLang xmlSpace y1 y2 y
fontSize fx fy gradientTransform gradientUnits marker
markerEnd markerHeight markerMid markerStart markerUnits
markerWidth offset opacity orient patternContentUnits
patternUnits points preserveAspectRatio r refX refY rx ry
spreadMethod stopColor stopOpacity stroke strokeDasharray
strokeLinecap strokeOpacity strokeWidth textAnchor transform
version viewBox x1 x2 x xlinkActuate xlinkArcrole xlinkHref
xlinkRole xlinkShow xlinkTitle xlinkType xmlBase xmlLang
xmlSpace y1 y2 y
```
20 changes: 11 additions & 9 deletions docs/docs/ref-04-tags-and-attributes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ thead time title tr track u ul var video wbr
The following SVG elements are supported:

```
circle clipPath defs ellipse g line linearGradient mask path pattern polygon polyline
radialGradient rect stop svg text tspan
circle clipPath defs ellipse g line linearGradient marker mask path pattern polygon
polyline radialGradient rect stop svg text tspan
```

You may also be interested in [react-art](https://github.com/facebook/react-art), a drawing library for React that can render to Canvas, SVG, or VML (for IE8).
Expand Down Expand Up @@ -80,11 +80,13 @@ There is also the React-specific attribute `dangerouslySetInnerHTML` ([more here

```
clipPath cx cy d dx dy fill fillOpacity fontFamily
fontSize fx fy gradientTransform gradientUnits markerEnd
markerMid markerStart offset opacity patternContentUnits
patternUnits points preserveAspectRatio r rx ry spreadMethod
stopColor stopOpacity stroke strokeDasharray strokeLinecap
strokeOpacity strokeWidth textAnchor transform version
viewBox x1 x2 x xlinkActuate xlinkArcrole xlinkHref xlinkRole
xlinkShow xlinkTitle xlinkType xmlBase xmlLang xmlSpace y1 y2 y
fontSize fx fy gradientTransform gradientUnits marker
markerEnd markerHeight markerMid markerStart markerUnits
markerWidth offset opacity orient patternContentUnits
patternUnits points preserveAspectRatio r refX refY rx ry
spreadMethod stopColor stopOpacity stroke strokeDasharray
strokeLinecap strokeOpacity strokeWidth textAnchor transform
version viewBox x1 x2 x xlinkActuate xlinkArcrole xlinkHref
xlinkRole xlinkShow xlinkTitle xlinkType xmlBase xmlLang
xmlSpace y1 y2 y
```
1 change: 1 addition & 0 deletions src/isomorphic/classic/element/ReactDOMFactories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ var ReactDOMFactories = mapObject({
image: 'image',
line: 'line',
linearGradient: 'linearGradient',
marker: 'marker',
mask: 'mask',
path: 'path',
pattern: 'pattern',
Expand Down
12 changes: 12 additions & 0 deletions src/renderers/dom/shared/SVGDOMPropertyConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,23 @@ var SVGDOMPropertyConfig = {
fy: MUST_USE_ATTRIBUTE,
gradientTransform: MUST_USE_ATTRIBUTE,
gradientUnits: MUST_USE_ATTRIBUTE,
marker: MUST_USE_ATTRIBUTE,
markerEnd: MUST_USE_ATTRIBUTE,
markerHeight: MUST_USE_ATTRIBUTE,
markerMid: MUST_USE_ATTRIBUTE,
markerStart: MUST_USE_ATTRIBUTE,
markerUnits: MUST_USE_ATTRIBUTE,
markerWidth: MUST_USE_ATTRIBUTE,
offset: MUST_USE_ATTRIBUTE,
orient: MUST_USE_ATTRIBUTE,
opacity: MUST_USE_ATTRIBUTE,
patternContentUnits: MUST_USE_ATTRIBUTE,
patternUnits: MUST_USE_ATTRIBUTE,
points: MUST_USE_ATTRIBUTE,
preserveAspectRatio: MUST_USE_ATTRIBUTE,
r: MUST_USE_ATTRIBUTE,
refX: MUST_USE_ATTRIBUTE,
refY: MUST_USE_ATTRIBUTE,
rx: MUST_USE_ATTRIBUTE,
ry: MUST_USE_ATTRIBUTE,
spreadMethod: MUST_USE_ATTRIBUTE,
Expand Down Expand Up @@ -97,11 +104,16 @@ var SVGDOMPropertyConfig = {
gradientTransform: 'gradientTransform',
gradientUnits: 'gradientUnits',
markerEnd: 'marker-end',
markerHeight: 'markerHeight',
markerMid: 'marker-mid',
markerStart: 'marker-start',
markerUnits: 'markerUnits',
markerWidth: 'markerWidth',
patternContentUnits: 'patternContentUnits',
patternUnits: 'patternUnits',
preserveAspectRatio: 'preserveAspectRatio',
refX: 'refX',
refY: 'refY',
spreadMethod: 'spreadMethod',
stopColor: 'stop-color',
stopOpacity: 'stop-opacity',
Expand Down