Skip to content

'getElementsByClassName' doesn't exist in IE8 #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
subtleGradient merged 1 commit into from
Nov 25, 2013
Merged

'getElementsByClassName' doesn't exist in IE8 #596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/core/__tests__/ReactMountDestruction-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,17 +43,13 @@ describe('ReactMount', function() {
React.renderComponent(instanceTwo, secondRootDiv);

// Test that two react roots are rendered in isolation
expect(firstRootDiv.getElementsByClassName('firstReactDiv').length)
.toBe(1);
expect(secondRootDiv.getElementsByClassName('secondReactDiv').length)
.toBe(1);
expect(firstRootDiv.firstChild.className).toBe('firstReactDiv');
expect(secondRootDiv.firstChild.className).toBe('secondReactDiv');

// Test that after unmounting each, they are no longer in the document.
React.unmountComponentAtNode(firstRootDiv);
expect(firstRootDiv.getElementsByClassName('firstReactDiv').length)
.toBe(0);
expect(firstRootDiv.firstChild).toBeNull();
React.unmountComponentAtNode(secondRootDiv);
expect(secondRootDiv.getElementsByClassName('secondReactDiv').length)
.toBe(0);
expect(secondRootDiv.firstChild).toBeNull();
});
});