Skip to content

Conversation

@vslinko
Copy link

@vslinko vslinko commented Feb 27, 2016

Fix for #6114

I guess that we should reject update to prevent "maximum call stack" error.
@jimfb what are you think?

@gaearon
Copy link
Collaborator

gaearon commented Feb 28, 2016

I’m afraid there is already work in progress in #6121 — it wasn’t linked to from the issue. I added a link.

@gaearon
Copy link
Collaborator

gaearon commented Mar 1, 2016

I’ll close since work on #6121 started earlier, is pretty close to being done, and uses the devtool API that we try to use for new warnings. Thanks for contributing!

@gaearon gaearon closed this Mar 1, 2016
@vslinko vslinko deleted the no-setState-in-getChildContext branch March 1, 2016 19:28
@raineroviir
Copy link

Thank you vslinko! I used where you were placing the code as the way to fix the issue

@vslinko
Copy link
Author

vslinko commented Mar 5, 2016

I'm glad to hear that 😄
But please link your future PRs to the issues.

@raineroviir
Copy link

Yeah I will that's on me!
On Sat, Mar 5, 2016 at 12:28 AM Vyacheslav Slinko notifications@github.com
wrote:

I'm glad to hear that [image: 😄]
But please link your future PRs to the issues.


Reply to this email directly or view it on GitHub
#6135 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants