Make ReactComponentTreeDevtool work with React Native #6633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
What's the test plan here? You should probably test this in the actual React Native environment since our tests here are still poor. |
Collaborator
Author
|
Will do tomorrow! |
ghost
added
the
Collaborator
Author
|
Works well with
|
|
@gaearon updated the pull request. |
zpao
pushed a commit
that referenced
this pull request
May 10, 2016
Make ReactComponentTreeDevtool work with React Native (cherry picked from commit 45ec126)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes #6549 work with React Native.
Note the big test is the key part but GitHub UI skips it:
https://github.com/gaearon/react/blob/6173bdd6c460a5fa5cb8547c57dd789b946848a9/src/isomorphic/devtools/__tests__/ReactComponentTreeDevtool-test.native.js
I copy-pasted all tests from the main suite but edited to reflect some specifics of RN.