Don't warn when style value is '0' #6677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zpao
force-pushed
the
dont-warn-css-0-string
branch
from
852c64a to
fa89cf5
Compare
|
@zpao updated the pull request. |
Collaborator
|
LGTM |
Collaborator
|
(I believe you’ll need #6458 when cherry-picking this though?) |
Member
Author
I'll special case this and cherry-pick just the 2nd commit here instead of landing and reverting. |
zpao
added a commit
to zpao/react
that referenced
this pull request
Jun 8, 2016
Don't warn when style value is '0' (cherry picked from commit 5c6f9d3)
zpao
added a commit
that referenced
this pull request
Jun 14, 2016
Don't warn when style value is '0' (cherry picked from commit 5c6f9d3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #6458 and then implements the goal of that PR without affecting the output.
While I agree that #6458 is "safe", it's a subtle behavior change in the generated output and I think we shouldn't take it in the branch. In
masterwe should make the change to stop appendingpxto all strings (not just'0').