Fix TestUtils crash with NODE_ENV=production#7246
Merged
gaearon merged 1 commit intofacebook:masterfrom Jul 14, 2016
gaearon:fix-testutils-crash
Merged
Fix TestUtils crash with NODE_ENV=production#7246gaearon merged 1 commit intofacebook:masterfrom gaearon:fix-testutils-crash
gaearon merged 1 commit intofacebook:masterfrom
gaearon:fix-testutils-crash
Conversation
ghost
added
| if (__DEV__) { | ||
| this._debugID = nextDebugID++; | ||
| var displayName = element.type.displayName || element.type.name || 'Unknown'; | ||
| ReactInstrumentation.debugTool.onSetDisplayName(this._debugID, displayName); |
Collaborator
Author
There was a problem hiding this comment.
I looked for it again, and this is the only unguarded debugTool call in the codebase. I missed it the last time because I didn’t realize TestUtils could be run in production mode.
Member
|
👍 |
|
Any chance we might see this in a 15.2.2 hot fix release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I caused it with #7189.
We generally don’t recommend running TestUtils in production environment but this is technically a regression.
Fixes #7231.