Fix benchmarks #7704
Merged
Fix benchmarks #7704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ## Running the suite | ||
|
|
||
| You'll need two folders to compare, each of them containing `react.min.js` and `react-dom-server.min.js`. You can run `npm run build` at the repo root to get a `build` folder with these files. |
Collaborator
There was a problem hiding this comment.
It would be nice if there was an easier way to run against a release build without manually recreating the build folder.
Collaborator
|
lgtm |
Member
|
Note: cherry-picking c0007d5 over to 15-stable as well to make this work. |
zpao
pushed a commit
that referenced
this pull request
Oct 4, 2016
(cherry picked from commit 3fcba20)
Collaborator
Author
|
Hmm. Maybe I shouldn't have tagged it at all? It's not touching the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They got broken at some point due to us no longer putting
ReactDOMServerguts intoreact.min.js. This fixes them and adds some instructions for first-time users like me.