Added onChange/requestChange support to LinkedInput #7793
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
LinkedInputto be actually useful as a replacement forvalueLink/checkedLinkon regularinputelements, it needs to triggerrequestChangeof theReactLinkobject. This can be achieved by this one-line change.I wanted to add a corresponding test, but for tests to work for me locally, I had to revert parts of #7168, which I assume is going in a wrong direction.
A couple of additional notes on the tests:
grunt testas both the folder name is wrong and thepackagesfolder is not intestPathDirsofpackage.jsonreact-linked-inputand since I couldn't find instructions on how to build that package, I gave up on fixing the tests.