[Fiber] Don't call componentDidUpdate if shouldComponentUpdate returns false#8028
Merged
sebmarkbage merged 1 commit intofacebook:masterfrom Oct 25, 2016
Merged
Conversation
82a616f to
2b3b7c6
Compare
sophiebits
approved these changes
Oct 25, 2016
| expect(ops).toEqual([ | ||
| 'componentWillReceiveProps', | ||
| 'shouldComponentUpdate', | ||
| // no componenWillUpdate |
This fix relies on the props and state objects being different to know if we can avoid a componentDidUpdate. This is not a great solution because we actually want to use the new props/state object even if sCU returns false. That's the current semantics and it can actually be important because new rerenders that are able to reuse props objects are more likely to have the new props object so we won't be able to quickly bail out next time. I don't have a better idea atm though.
2b3b7c6 to
46bde58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #8015
This fix relies on the props and state objects being different to know if we can avoid a componentDidUpdate. This is not a great solution because we actually want to use the new props/state object even if sCU returns false. That's the current semantics and it can actually be important because new parent rerenders that are able to reuse props objects are more likely to have the new props object so we won't be able to quickly bail out next time. For example:
I don't have a better idea atm though.