Fix ReactDOMImg redefining tagName

[syranide]

Shouldn't be there right?

[sophiebits]

@vjeux said it needs to be there for some internal FB tests. I'd think those should be changed too; otherwise we should add tagName to all the wrappers for consistency.

[vjeux]

ReactTestUtils are assuming that tagName is defined on all the DOM properties.

react/src/test/ReactTestUtils.js

Line 58 in 1b67ac9

isDOMComponent: function(inst) {

react/src/test/ReactTestUtils.js

Line 144 in 1b67ac9

scryRenderedDOMComponentsWithTag: function(root, tagName) {

react/src/test/ReactTestUtils.js

Line 157 in 1b67ac9

findRenderedDOMComponentWithTag: function(root, tagName) {

I feel like we should add tagName to all the DOM tags instead of removing them

[sophiebits]

Well, isDOMComponent should probably be false if it's a composite component.

[syranide]

@vjeux But can't ReactDOMComponent do that globally then? Oh wait, I thought they were extending ReactDOMComponent but they're extending ReactCompositeComponent, yeah this is sound.

[vjeux]

We use those test util methods in a handful of places internally and they rely on the fact that tagName is defined. I don't see any downside of defining tagName for React.DOM components.

[syranide]

@vjeux I don't know enough about the internals, but couldn't these components just extend or mixin ReactDOMComponent instead?

[vjeux]

@spicyj ^^

[sophiebits]

I mean, they behave essentially like the composite component wrappers that they are, so that sounds sketchy to me. I can look a little more in depth later.