Add error codes update to release process#8749
Merged
gaearon merged 2 commits intofacebook:masterfrom Jan 12, 2017
Merged
Conversation
Collaborator
|
Seems like we need to add these instructions: #7999 (comment). Going to flag as needs revision, feel free to fix it, but I'll assign to myself to fix it up later. |
gaearon
requested changes
Jan 11, 2017
Collaborator
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
Need to do this on dev-branch (so this needs to happen earlier) and add a note about cherry-picking to master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@gaearon