Switch to shipping Fiber in npm packages #9015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
We actually planned to get rid of the separate export in the next alpha and instead enable it by default. Would you like to amend the PR for this? |
Contributor
Author
|
Sure, happy to do this. Do you need a way for users to opt out, like |
Collaborator
|
No. Supporting both at the same time has been and will be daunting. We'll want to completely cut over in the major and this is the first step. |
Contributor
Author
|
Done. I guess there is a bunch of files to be deleted now, but that's beyond my scope, sorry. |
gaearon
changed the title
fiber.js to npm
Collaborator
|
Looks fine, thanks! |
Contributor
|
Does this also switch the UMD builds, and if so, can we delete the Fiber UMD build? |
Collaborator
|
It doesn't switch UMDs, no. |
Contributor
Author
|
Of course. Here you go gentlemen #9026 |
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added missing
fiber.jstoreact-domandreact-test-rendererpackage.json-s so this file doesn't get stripped when packages are published to npm.