Skip to content

Switch UMD build to Fiber #9026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dsblv wants to merge 4 commits into from
Closed

Switch UMD build to Fiber #9026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17786c7
Switch ReactDOM UMD bundles to Fiber entry points
dsblv Feb 18, 2017
e7fe688
Remove Fiber UMD builds
dsblv Feb 18, 2017
f17fe67
Revert "Switch ReactDOM UMD bundles to Fiber entry points"
dsblv Feb 18, 2017
cab1c19
Require ReactDOMFiber for UMD build
dsblv Feb 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions Gruntfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,16 +139,6 @@ module.exports = function(grunt) {
'version-check',
'browserify:domServerMin',
]);
grunt.registerTask('build:dom-fiber', [
'build-modules',
'version-check',
'browserify:domFiber',
]);
grunt.registerTask('build:dom-fiber-min', [
'build-modules',
'version-check',
'browserify:domFiberMin',
]);
grunt.registerTask('build:npm-react', [
'version-check',
'build-modules',
Expand Down Expand Up @@ -176,8 +166,6 @@ module.exports = function(grunt) {
'browserify:domMin',
'browserify:domServer',
'browserify:domServerMin',
'browserify:domFiber',
'browserify:domFiberMin',
'npm-react:release',
'npm-react:pack',
'npm-react-dom:release',
Expand Down
34 changes: 0 additions & 34 deletions grunt/config/browserify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,38 +268,6 @@ var domServerMin = {
after: [wrapperify, minify, bannerify],
};

var domFiber = {
entries: [
'./build/node_modules/react-dom/lib/ReactDOMFiber.js',
],
outfile: './build/react-dom-fiber.js',
debug: false,
standalone: 'ReactDOMFiber',
// Apply as global transform so that we also envify fbjs and any other deps
transforms: [shimSharedModules],
globalTransforms: [envifyDev],
plugins: [collapser],
after: [derequire, wrapperify, simpleBannerify],
};

var domFiberMin = {
entries: [
'./build/node_modules/react-dom/lib/ReactDOMFiber.js',
],
outfile: './build/react-dom-fiber.min.js',
debug: false,
standalone: 'ReactDOMFiber',
// Envify twice. The first ensures that when we uglifyify, we have the right
// conditions to exclude requires. The global transform runs on deps.
transforms: [shimSharedModules, envifyProd, uglifyify],
globalTransforms: [envifyProd],
plugins: [collapser],
// No need to derequire because the minifier will mangle
// the "require" calls.

after: [wrapperify, minify, bannerify],
};

module.exports = {
basic: basic,
min: min,
Expand All @@ -309,6 +277,4 @@ module.exports = {
domMin: domMin,
domServer: domServer,
domServerMin: domServerMin,
domFiber: domFiber,
domFiberMin: domFiberMin,
};
2 changes: 1 addition & 1 deletion src/umd/ReactDOMUMDEntry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
'use strict';

var React = require('React');
var ReactDOM = require('ReactDOM');
var ReactDOM = require('ReactDOMFiber');

var ReactDOMUMDEntry = ReactDOM;

Expand Down