Skip to content

Improve component type check in getComponentKey. #9464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bvaughn merged 2 commits into from
Apr 25, 2017
Merged

Improve component type check in getComponentKey. #9464

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e53a29
Improve component type check in getComponentKey.
bmeurer Apr 20, 2017
bc2479f
Run yarn prettier.
bmeurer Apr 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/isomorphic/children/traverseAllChildren.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@ var didWarnAboutMaps = false;
function getComponentKey(component, index) {
// Do some typechecking here since we call this blindly. We want to ensure
// that we don't block potential future ES APIs.
if (component && typeof component === 'object' && component.key != null) {
if (
typeof component === 'object' && component !== null && component.key != null
) {
// Explicit key
return KeyEscapeUtils.escape(component.key);
}
Expand Down