Skip to content

Conversation

@syranide
Copy link
Contributor

No one must find out :)

Thanks for @plievone for pointing it out, #934

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So are these tests not actually testing anything?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zpao Work computer bugged out so I can't access it from home, they're OK I think, it's just that the ID they set is (basically) irrelevant.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see now. That's deceptive.

zpao added a commit that referenced this pull request Jan 31, 2014
Fix references to the old ReactID syntax
@zpao zpao merged commit fce6d11 into facebook:master Jan 31, 2014
@syranide syranide deleted the hidethekill branch January 31, 2014 23:35
@syranide syranide restored the hidethekill branch March 5, 2014 10:13
@syranide syranide deleted the hidethekill branch April 9, 2014 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants