Skip to content

Download bzip2 packages from sourceforge#5995

Closed
Myasuka wants to merge 2 commits intofacebook:masterfrom
Myasuka:download-bzip2
Closed

Download bzip2 packages from sourceforge#5995
Myasuka wants to merge 2 commits intofacebook:masterfrom
Myasuka:download-bzip2

Conversation

@Myasuka
Copy link
Copy Markdown
Contributor

@Myasuka Myasuka commented Nov 1, 2019

From bzip2's official download page, we could download it from sourceforge. This source would be more credible than previous web archive.

From bzip2's official [download page](http://www.bzip.org/downloads.html), we could download it from sourceforge. This source would be more credible than previous web archive.
@Myasuka
Copy link
Copy Markdown
Contributor Author

Myasuka commented Nov 1, 2019

There is another reason why we need to merge this, web.archive.org is currently not stable in China and usually blocked, which makes developers in China not so easy to build RocksDB.

@siying siying requested a review from adamretter November 1, 2019 17:03
@siying
Copy link
Copy Markdown
Contributor

siying commented Nov 7, 2019

@adamretter any comment?

@adamretter
Copy link
Copy Markdown
Collaborator

@siying Sorry for the delay, somehow I missed this one. Assuming that the link is correct, then this looks fine to me as the checksum has not changed.

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siying is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 07a0ad3.

merryChris pushed a commit to merryChris/rocksdb that referenced this pull request Nov 18, 2019
Summary:
From bzip2's official [download page](http://www.bzip.org/downloads.html), we could download it from sourceforge. This source would be more credible than previous web archive.
Pull Request resolved: facebook#5995

Differential Revision: D18377662

fbshipit-source-id: e8353f83d5d6ea6067f78208b7bfb7f0d5b49c05
adamretter pushed a commit to adamretter/rocksdb that referenced this pull request Mar 7, 2020
Summary:
From bzip2's official [download page](http://www.bzip.org/downloads.html), we could download it from sourceforge. This source would be more credible than previous web archive.
Pull Request resolved: facebook#5995

Differential Revision: D18377662

fbshipit-source-id: e8353f83d5d6ea6067f78208b7bfb7f0d5b49c05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants