Skip to content

[legacy] Fix Huffman jump table reads in v01 and v05#1594

Merged
terrelln merged 1 commit intofacebook:devfrom
terrelln:legacy-fix
Apr 19, 2019
Merged

[legacy] Fix Huffman jump table reads in v01 and v05#1594
terrelln merged 1 commit intofacebook:devfrom
terrelln:legacy-fix

Conversation

@terrelln
Copy link
Contributor

  • We would read the jump table before checking the source size.
  • The v05 bug was caught by the simple_decompress fuzzer now that we are running with legacy support enabled.
  • The v01 bug was caught by manual inspection.
  • All the other legacy versions seem to check the header correctly.

@terrelln terrelln merged commit 9ad7ea4 into facebook:dev Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants