Fix #1591 - Not building on MinGW-W64#1600
Fix #1591 - Not building on MinGW-W64#1600terrelln merged 1 commit intofacebook:devfrom myzhang1029:long-tell
Conversation
Add a static function LONG_TELL for the forth #if branch
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
terrelln
left a comment
terrelln
left a comment
There was a problem hiding this comment.
Awesome! Thanks for the patch!
|
I will merge this once the bot tags this as CLA signed. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Fixes #1591. |
3 participants
Add a static function
LONG_TELLfor the forth#ifbranchIt looks like the only way to invoke the edited code is through the
--listoption of the cli.I tested it on a Windows 7 machine, for both small and large(3 GiB) files, and they worked as expected.