Make zstdcat to follow symbolic links#1604
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
terrelln
left a comment
There was a problem hiding this comment.
Thanks for the patch!
Note for others that see this issue, until the next zstd release this can be worked around by using with zstdcat -f.
|
Oh, nearly forgot! Would you mind adding a test to tests/playTests.sh that makes sure it works If you don't have the time, let me know and I can add the test myself. If I don't hear back in a few days I'll go ahead and merge and add the test. |
Since #1520 has been merged, commands like zstdcat properly detect symbolic links on Linux. But the consequence is that they output nothing when executed on a symbolic link. According to the manual, zstdcat includes -f, which should follow symbolic links. This is also how most *cat commands like zcat behave.
Please comment and I would be glad if you could consider this request for merging into master. Thanks.
Charles