Merged
Conversation
This commit fixes error when running playTests.sh in Meson. Mesonbuild runs out of tree, so ./datagen not in `zstd/tests` dir, it lies in <mesonbuilddir>/tests. This leads to ../programs invalid.
terrelln
reviewed
May 1, 2019
Contributor
terrelln
left a comment
There was a problem hiding this comment.
The changes to playTests.sh look okay, but we'll have to see if it is working on BSD and Windows.
Contributor
Author
|
Spurious fail in ARM Fuzz test? Could you restart it, @terrelln ? |
Contributor
Author
|
Never mind. I force-pushed new changes. |
Contributor
|
The failing poolTest is not a problem with meson. It was broken by #1581. I'll let you know when it is fixed. |
Use std=gnu99 to build and test just like `make test`.
c127994 to
8fba4bf
Compare
Run build under release mode for faster test time.
Contributor
Author
|
Hm, test-zstd time in Meson is long compare to other build jobs. Mostly Should I change it to release build? |
Contributor
Author
|
Result when tests are built with |
terrelln
approved these changes
May 2, 2019
Contributor
terrelln
left a comment
There was a problem hiding this comment.
Awesome, thanks!
I'll fix the pool test in a separate PR, it has some deadlocks and flakiness problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
One advantage of running meson test on CI is that tests are run
parallel by default. So test time is faster than running test with make.
Closes #1605