add cmake lz4 support#1626
Merged
Cyan4973 merged 2 commits intofacebook:devfrom Jun 19, 2019
LeeYoung624:dev
Merged
Conversation
add some instructions for build/cmake/README.md
Cyan4973
approved these changes
Jun 19, 2019
Contributor
|
Thanks for the patch @LeeYoung624 , |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some instructions in build/cmake/README.md for guys not familiar with cmake. Show them how to build with options
Yes, I saw there is a cmake support, but it can be improved using a CMakeLists.txt file and have a flag for each thing we want to build or not.
Add lz4 format support for zstd program, with a new cmake module FindLibLZ4.cmake added to find lz4 library.
This has been test on:
suse12sp2 cmake 3.12.1 lz4 1.8.3
windows10 cmake 3.12.1 lz4 1.8.3
ubuntu12.04 cmake 3.0.2 lz4 1.8.3
centos7.4 cmake 2.8.12 lz4 1.8.3
redhat7.2 cmake 3.0.2 lz4 1.8.3
with tests like:
lz4 compressed file->zstd decompress file->diff files
zstd compressed file->lz4 decompress file->diff files
Issue#715
I rebased my last pull request and restart a new pull request again