CMake bug fix: didn't install zstdless and zstdgrep.#1647
Merged
Cyan4973 merged 1 commit intofacebook:devfrom Jun 15, 2019
LeeYoung624:cmake_bug_fix
Merged
CMake bug fix: didn't install zstdless and zstdgrep.#1647Cyan4973 merged 1 commit intofacebook:devfrom LeeYoung624:cmake_bug_fix
Cyan4973 merged 1 commit intofacebook:devfrom
LeeYoung624:cmake_bug_fix
Conversation
|
The commit itself might be improved, I suggest something like this: |
Contributor
Author
|
@Mno-hime Do you mean that the commit message should be more specific? |
|
Yes, subject of the pull request is ok, but the commit message can be more specific about what's happening in the commit. |
Contributor
Author
|
Sure, I think you are right. Thank you so much @Mno-hime . |
felixhandte
requested changes
Jun 11, 2019
Contributor
felixhandte
left a comment
felixhandte
left a comment
There was a problem hiding this comment.
Thanks for fixing the stack! I have one last suggested change: it would be cleaner if you could use ${PROGRAMS_DIR}/ rather than ${CMAKE_SOURCE_DIR}/../../programs/. Will that work? And if so, can you switch to that?
Thanks!
Contributor
Author
|
Sure. I have switched to this. |
Cyan4973
approved these changes
Jun 15, 2019
Contributor
|
Thanks @LeeYoung624 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake bug fix: CMake didn't install zstdless and zstdgrep.
I mess up the last PR#1625 and create a new PR here.
Really sorry about this. @felixhandte