Skip to content

decodecorpus #1664

Merged
Cyan4973 merged 7 commits intofacebook:devfrom
ephiepark:dev
Jul 1, 2019
Merged

decodecorpus #1664
Cyan4973 merged 7 commits intofacebook:devfrom
ephiepark:dev

Conversation

@ephiepark
Copy link
Contributor

Decoder was enforcing a constraint that is more strict than the spec. Sequence section for a compressed block can be less than the constraint that was enforced by decoder. When a block with rle mode for all (literal length, match length, and offset) is followed by another block with repeat mode for all (literal length, match length, and offset), the second block's sequence section can be 2 bytes (1 byte for number of sequences and 1 byte for compression mode for each field).

This pull request includes 2 changes.

  1. fixing the decoder code to remove the constraint.
  2. Updating decodecorpus code to generate repeat after rle mode.

Run ./decodecorpus -ptestfiles -otestfiles -n1 -s1236947365 -v to generate an input that has an issue before the fix.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants