Merged
Conversation
Cyan4973
approved these changes
Jul 3, 2019
Contributor
|
Looks fine, there is a just minor implicit cast warning to fix, nothing alarming. |
ephiepark
force-pushed
the
dev
branch
2 times, most recently
from
9551d06 to
0a9b5a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request only adds targetCBlockSize as an advanced parameter for ZSTD compression. At the moment changing its value won't have any impact on compression. The implementation of super block compression will follow as a separate PR.