Skip to content

ZSTD_seekable_decompress() example that hangs.#2505

Closed
mlindsay wants to merge 1 commit intofacebook:devfrom
mlindsay:dev
Closed

ZSTD_seekable_decompress() example that hangs.#2505
mlindsay wants to merge 1 commit intofacebook:devfrom
mlindsay:dev

Conversation

@mlindsay
Copy link
Contributor

@mlindsay mlindsay commented Feb 22, 2021

This generates a hang using the zstd_seekable format. It is contrived as it was generated using the fuzzer at https://fuchsia.googlesource.com/fuchsia/+/6c0911153a4b36d5a6ab86f74cc9d1a313d8e8ca/src/storage/blobfs/test/zstd-seekable-fuzzer.cc but it should return an error for an invalid archive instead of hanging.

This change is just a reference for issue #2506

@facebook-github-bot
Copy link

Hi @mlindsay!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@mlindsay mlindsay marked this pull request as ready for review February 22, 2021 16:14
@senhuang42 senhuang42 self-assigned this Feb 26, 2021
@senhuang42
Copy link

Big thanks for noticing this and writing out this test case! We've fixed the issue in #2516 (including your test case) and added a roundtrip seekable fuzzer #2617 here.

@senhuang42 senhuang42 closed this May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants