[regression] Update results.csv#2508
Merged
terrelln merged 1 commit intofacebook:devfrom Feb 24, 2021
Merged
Conversation
9f327c0 changed the compression method for LDM, so the results are slightly different. I've re-tested LDM on some larger inputs and everything seems fine. These ratio changes just seem to be noise. There is generally a 0.01% swing in ratio, sometimes better sometimes worse, but never large.
Cyan4973
approved these changes
Feb 24, 2021
terrelln
added a commit
to terrelln/zstd
that referenced
this pull request
Feb 25, 2021
Fixes the update from PR facebook#2508. I had accidentally forgotten to rebuild the library, and the regression test suite isn't hooked up to the new fancy build system yet. I've double checked that the results are deterministic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
9f327c0 changed the compression method
for LDM, so the results are slightly different.
I've re-tested LDM on some larger inputs and everything seems fine.
These ratio changes just seem to be noise. There is generally a 0.01%
swing in ratio, sometimes better sometimes worse, but never large.