Skip to content

Make the number of physical CPU cores detection more robust#2517

Merged
senhuang42 merged 2 commits intofacebook:devfrom
PaulBone:num_cores
Mar 8, 2021
Merged

Make the number of physical CPU cores detection more robust#2517
senhuang42 merged 2 commits intofacebook:devfrom
PaulBone:num_cores

Conversation

@PaulBone
Copy link
Contributor

@PaulBone PaulBone commented Mar 3, 2021

Bad data in /proc/cpuinfo can cause this calculation to divide by zero. While there's clearly a bug in my kernel causing a weird /proc/cpuinfo it's a good idea to make zstd robust to bad/weird data like this.

@facebook-github-bot
Copy link

Hi @PaulBone!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Copy link

@senhuang42 senhuang42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @PaulBone! Looks like you just have to sign the CLA.

@PaulBone
Copy link
Contributor Author

PaulBone commented Mar 3, 2021

Thanks for the PR @PaulBone! Looks like you just have to sign the CLA.

Hi @senhuang42
My colleague Daniel Nazer dnazer@mozilla.com sent a message to cla@fb.com to add me to Mozilla's CLA agreement.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@senhuang42 senhuang42 merged commit a3feed8 into facebook:dev Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants