Make the number of physical CPU cores detection more robust#2517
Make the number of physical CPU cores detection more robust#2517senhuang42 merged 2 commits intofacebook:devfrom
Conversation
|
Hi @PaulBone! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
senhuang42
left a comment
There was a problem hiding this comment.
Thanks for the PR @PaulBone! Looks like you just have to sign the CLA.
Hi @senhuang42 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Bad data in
/proc/cpuinfocan cause this calculation to divide by zero. While there's clearly a bug in my kernel causing a weird/proc/cpuinfoit's a good idea to make zstd robust to bad/weird data like this.