Reduce stack usage of ZSTD_buildCTable()#2522
Merged
terrelln merged 1 commit intofacebook:devfrom Mar 5, 2021
Merged
Conversation
Cyan4973
reviewed
Mar 4, 2021
| assert(entropyWorkspaceSize >= FSE_BUILD_CTABLE_WORKSPACE_SIZE(MaxSeq, MaxFSELog)); | ||
| FORWARD_IF_ERROR(FSE_normalizeCount(norm, tableLog, count, nbSeq_1, max, ZSTD_useLowProbCount(nbSeq_1)), ""); | ||
| { size_t const NCountSize = FSE_writeNCount(op, oend - op, norm, max, tableLog); /* overflow protected */ | ||
| RETURN_ERROR_IF(entropyWorkspaceSize < sizeof(ZSTD_BuildCTableWksp), GENERIC, "wksp too small"); |
Contributor
There was a problem hiding this comment.
minor: if you believe that passing a too small entropyWorkspaceSize is something that should never happen if the code is correct, then using an assert() instead of a runtime error check would be appropriate here.
Cyan4973
approved these changes
Mar 4, 2021
terrelln
force-pushed
the
stack-reduction
branch
from
6803a11 to
27498ff
Compare
It is a stack high-point for some compression strategies and has an easy fix. This moves the normalized count into the entropy workspace.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a stack high-point for some compression strategies and has an easy fix. This moves the normalized count into the entropy workspace.