Fixes for the next linux kernel patch version#2539
Merged
terrelln merged 6 commits intofacebook:devfrom Mar 24, 2021
Merged
Conversation
Fix the `unaligned.h` shim in the tests that was causing corruption in the tests. Note that this is a problem with the test shim, not the kernel code.
Update the test include stubs so they are able to run the current zstd version in the kernel, so I can compare stack usage.
Expose the zstd headers in `include/linux` to avoid struct duplication. This makes the member names not follow Kernel style guidelines, and exposes the zstd symbols. But, the LMKL reviewers are okay with that.
Remove tracing support from `freestanding.py` to keep things simple.
When defined, it disables tracing, and avoids including the header.
Cyan4973
approved these changes
Mar 24, 2021
terrelln
added a commit
that referenced
this pull request
Mar 24, 2021
Fixes for the next linux kernel patch version
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm going to update the patch set to the latest dev, instead of staying on
zstd-1.4.6, so we're not releasing old code.1.4.10zstd.haszstd_lib.hin the linux kernel to avoid struct redefinitionsZSTD_NO_TRACEmacro to force tracing disabling & avoid needing the headerunalign.hand support the current zstd version in the kernel for testingI also want to wait for PR #2538 and PR #2524 to be resolved.